Re: SCTP_HMAC_NONE config variable is unused

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert P. J. Day wrote:
>   that config variable is defined but unreferenced anywhere in the
> tree.
> 
> rday

Yep.  It could probably be use used here:

include/net/sctp/constants.h:

#if defined (CONFIG_SCTP_HMAC_MD5)
#define SCTP_COOKIE_HMAC_ALG "hmac(md5)"
#elif defined (CONFIG_SCTP_HMAC_SHA1)
#define SCTP_COOKIE_HMAC_ALG "hmac(sha1)"
#else
#define SCTP_COOKIE_HMAC_ALG NULL
#endif


the final '#else' can be:

#elif defined (CONFIG_SCTP_HMAC_NONE)


An alternative would be to change the 'choice' in Kconfig
to something else that allows us to have a 'none' selection.

Is this really a problem?

-vlad
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux