Vlad, Thanks for your comments. Vlad Yasevich wrote: > Gui Jianfeng wrote: >> Vlad, >> This patch enables cookie-echo retransmission transport switch >> feature. If COOKIE-ECHO retransmission happens, it will be sent to the >> address other than the one last sent to. >> > > NAK. > > You can't blindly choose a different transport since they could > be unconfirmed and can't really be used until we confirm them > with HBs. So, you can only do this when the user issued an > sctp_connectx() and we have multiple confirmed transports. > > In this case only confirmed transports are allowed, otherwise > there is a possibility of hijacking associations. > Choosing a transport here just gives a suggestion for sctp_outq_flush(), sctp_outq_flush() will judge again. If the selected transport is in INACTIVE or UNCONFIRMED, active_path will be used. So COOKIE-ECHO won't be sent to a unconfirmed address. > > Also, looking at this, the same problem exists in current > code for selection INIT transports. > > We don't correctly treat peers passed to connectx() as confirmed > and don't select the correct transport. > > Once you fix that above, you can just re-use the function and > re-use init_last_sent_to. Will do. > > -vlad > > > -- Regards Gui Jianfeng -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
