> -----Original Message----- > From: Baoyou Xie [mailto:baoyou.xie@xxxxxxxxxx] > Sent: Monday, September 26, 2016 5:31 PM > To: subbu.seetharaman@xxxxxxxxxxxx; ketan.mukadam@xxxxxxxxxxxx; > jitendra.bhivare@xxxxxxxxxxxx; jejb@xxxxxxxxxxxxxxxxxx; > martin.petersen@xxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; arnd@xxxxxxxx; > baoyou.xie@xxxxxxxxxx; xie.baoyou@xxxxxxxxxx; han.fei@xxxxxxxxxx; > tang.qiang007@xxxxxxxxxx > Subject: [PATCH] scsi: be2iscsi: mark symbols static where possible > > We get 6 warnings when building kernel with W=1: > drivers/scsi/be2iscsi/be_main.c:65:1: warning: no previous prototype for > 'beiscsi_log_enable_disp' [-Wmissing-prototypes] > drivers/scsi/be2iscsi/be_main.c:78:1: warning: no previous prototype for > 'beiscsi_log_enable_change' [-Wmissing-prototypes] > drivers/scsi/be2iscsi/be_main.c:97:1: warning: no previous prototype for > 'beiscsi_log_enable_store' [-Wmissing-prototypes] > drivers/scsi/be2iscsi/be_main.c:116:1: warning: no previous prototype for > 'beiscsi_log_enable_init' [-Wmissing-prototypes] > drivers/scsi/be2iscsi/be_main.c:4587:5: warning: no previous prototype for > 'beiscsi_iotask_v2' [-Wmissing-prototypes] > drivers/scsi/be2iscsi/be_main.c:4976:6: warning: no previous prototype for > 'beiscsi_hba_attrs_init' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are declared and > don't need a declaration, but can be made static. > > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx> > --- [JB] Looks good. Reviewed by: Jitendra Bhivare <Jitendra.bhivare@broadcom> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
