Re: [PATCH next] scsi: fcoe: fix off by one in eth2fc_speed()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 21, 2016 at 10:54:07PM +0200, Vincent Stehlé wrote:
> This should be "< ARRAY_SIZE()" instead of "<= ARRAY_SIZE()".
> 
> Fixes: 0b924e5505a568e7 ("scsi: fcoe: provide translation table between Ethernet and FC port speeds")
> Signed-off-by: Vincent Stehlé <vincent.stehle@xxxxxxxxxxx>
> Cc: Johannes Thumshirn <jthumshirn@xxxxxxx>
> Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> ---
> 
> Hi,
> 
> I saw that in Linux next-20160921.
> 
> Best regards,
> 
> Vincent.
> 
>  drivers/scsi/fcoe/fcoe_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
> index c164eec..375c536 100644
> --- a/drivers/scsi/fcoe/fcoe_transport.c
> +++ b/drivers/scsi/fcoe/fcoe_transport.c
> @@ -110,7 +110,7 @@ static inline u32 eth2fc_speed(u32 eth_port_speed)
>  {
>  	int i;
>  
> -	for (i = 0; i <= ARRAY_SIZE(fcoe_port_speed_mapping); i++) {
> +	for (i = 0; i < ARRAY_SIZE(fcoe_port_speed_mapping); i++) {
>  		if (fcoe_port_speed_mapping[i].eth_port_speed == eth_port_speed)
>  			return fcoe_port_speed_mapping[i].fc_port_speed;
>  	}
> -- 
> 2.9.3
> 

Good catch,
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux