>-----Original Message----- >From: Baoyou Xie [mailto:baoyou.xie@xxxxxxxxxx] >Sent: Sunday, September 18, 2016 5:38 PM >To: kashyap.desai@xxxxxxxxxxxxx; sumit.saxena@xxxxxxxxxxxxx; >uday.lingala@xxxxxxxxxxxxx; jejb@xxxxxxxxxxxxxxxxxx; >martin.petersen@xxxxxxxxxx >Cc: megaraidlinux.pdl@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; arnd@xxxxxxxx; baoyou.xie@xxxxxxxxxx; >xie.baoyou@xxxxxxxxxx >Subject: [PATCH] megaraid_sas: clean function declarations in >megaraid_sas_base.c up > >We get a few warnings when building kernel with W=1: >drivers/scsi/megaraid/megaraid_sas_fusion.c:281:1: warning: no previous >prototype for 'megasas_free_cmds_fusion' [-Wmissing-prototypes] >drivers/scsi/megaraid/megaraid_sas_fusion.c:714:1: warning: no previous >prototype for 'megasas_ioc_init_fusion' [-Wmissing-prototypes] .... > >In fact, these functions are declared in >drivers/scsi/megaraid/megaraid_sas_base.c, but should be declared in a header >file, thus can be recognized in other file. > >So this patch adds the declarations into >drivers/scsi/megaraid/megaraid_sas_fusion.h. > >Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx> >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 13 ------------- > drivers/scsi/megaraid/megaraid_sas_fusion.h | 9 +++++++++ > 2 files changed, 9 insertions(+), 13 deletions(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index 2d62d71..b73b6f3 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -189,25 +189,12 @@ u32 > megasas_build_and_issue_cmd(struct megasas_instance *instance, > struct scsi_cmnd *scmd); > static void megasas_complete_cmd_dpc(unsigned long instance_addr); -void - >megasas_release_fusion(struct megasas_instance *instance); -int - >megasas_ioc_init_fusion(struct megasas_instance *instance); -void - >megasas_free_cmds_fusion(struct megasas_instance *instance); >-u8 >-megasas_get_map_info(struct megasas_instance *instance); -int - >megasas_sync_map_info(struct megasas_instance *instance); int >wait_and_poll(struct megasas_instance *instance, struct megasas_cmd *cmd, > int seconds); >-void megasas_reset_reply_desc(struct megasas_instance *instance); void >megasas_fusion_ocr_wq(struct work_struct *work); static int >megasas_get_ld_vf_affiliation(struct megasas_instance *instance, > int initial); >-int megasas_check_mpio_paths(struct megasas_instance *instance, >- struct scsi_cmnd *scmd); > > int > megasas_issue_dcmd(struct megasas_instance *instance, struct megasas_cmd >*cmd) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h >b/drivers/scsi/megaraid/megaraid_sas_fusion.h >index 80eaee2..3fe730a 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h >+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h >@@ -991,5 +991,14 @@ union desc_value { > } u; > }; > >+void megasas_free_cmds_fusion(struct megasas_instance *instance); int >+megasas_ioc_init_fusion(struct megasas_instance *instance); >+u8 megasas_get_map_info(struct megasas_instance *instance); int >+megasas_sync_map_info(struct megasas_instance *instance); void >+megasas_release_fusion(struct megasas_instance *instance); void >+megasas_reset_reply_desc(struct megasas_instance *instance); int >+megasas_check_mpio_paths(struct megasas_instance *instance, >+ struct scsi_cmnd *scmd); >+void megasas_fusion_ocr_wq(struct work_struct *work); > > #endif /* _MEGARAID_SAS_FUSION_H_ */ Acked-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx> >-- >2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
