>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes:
Christoph> These should go together with the rest of the T10 protection
Christoph> information defintions.
Series looks good in general. However, now that you introduced t10-pi.h
it seems a bit odd to perpetuate the obsolete "DIF" terminology.
+enum t10_dif_type {
+ T10_DIF_TYPE0_PROTECTION = 0x0,
+ T10_DIF_TYPE1_PROTECTION = 0x1,
+ T10_DIF_TYPE2_PROTECTION = 0x2,
+ T10_DIF_TYPE3_PROTECTION = 0x3,
+};
How about?
enum t10_pi_type {
T10_PI_TYPE0_PROTECTION = 0x0,
T10_PI_TYPE1_PROTECTION = 0x1,
T10_PI_TYPE2_PROTECTION = 0x2,
T10_PI_TYPE3_PROTECTION = 0x3,
};
I don't mind fixing that up when I apply. Any objections?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
