Re: [PATCH v2 26/29] be2iscsi: Fix queue and connection parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/19/2016 11:50 AM, Jitendra Bhivare wrote:
> Current EQ delay is set to 0 to receive very high max interrupt per sec.
> Set EQ delay to 32 - reducing max interrupt rate from 65K to 20K per sec.
> 
> Set TCP connection window size to 64K with scale shift count 2.
> 
> Signed-off-by: Jitendra Bhivare <jitendra.bhivare@xxxxxxxxxxxx>
> ---
>  drivers/scsi/be2iscsi/be_main.c | 2 +-
>  drivers/scsi/be2iscsi/be_mgmt.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 50d865e..7c372b8 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -3729,7 +3729,7 @@ static int hwi_init_port(struct beiscsi_hba *phba)
>  	phwi_context = phwi_ctrlr->phwi_ctxt;
>  	phwi_context->max_eqd = 128;
>  	phwi_context->min_eqd = 0;
> -	phwi_context->cur_eqd = 0;
> +	phwi_context->cur_eqd = 32;
>  	/* set port optic state to unknown */
>  	phba->optic_state = 0xff;
>  
> diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
> index 736eca3..adc827b 100644
> --- a/drivers/scsi/be2iscsi/be_mgmt.c
> +++ b/drivers/scsi/be2iscsi/be_mgmt.c
> @@ -338,7 +338,7 @@ int mgmt_open_connection(struct beiscsi_hba *phba,
>  
>  	if (!is_chip_be2_be3r(phba)) {
>  		req->hdr.version = MBX_CMD_VER1;
> -		req->tcp_window_size = 0;
> +		req->tcp_window_size = 0x8000;
>  		req->tcp_window_scale_count = 2;
>  	}
>  
> 
Wouldn't it make sense to allow modifications here, eg via a module
parameters? From the description this should help reducing the latency
if required, no?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux