On 09/06/2016 05:36 PM, John Garry wrote: > The endianness for the SAS address in the TX_ID_DWORD > registers is set incorrectly. > We see errors like this in the boot log for v2 hw (which would > have the same issue as v1 hw): > [ 7.583284] sas: target proto 0x0 at 50000d1108e7923f:0x1f not handled > > This is due to the host SAS addr not matching the PHY SAS > addr in the expander host-attached phy discovery responses. > > To fix, we byte swap the SAS addr from BE to LE (which is > the endianness of the SAS controller). > > Signed-off-by: John Garry <john.garry@xxxxxxxxxx> > Signed-off-by: Xiang Chen <chenxiang66@xxxxxxxxxxxxx> > --- > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > index b537464..c030df0 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > @@ -490,13 +490,13 @@ static void config_id_frame_v1_hw(struct hisi_hba *hisi_hba, int phy_no) > hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD0, > __swab32(identify_buffer[0])); > hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD1, > - identify_buffer[2]); > + __swab32(identify_buffer[1])); > hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD2, > - identify_buffer[1]); > + __swab32(identify_buffer[2])); > hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD3, > - identify_buffer[4]); > + __swab32(identify_buffer[3])); > hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD4, > - identify_buffer[3]); > + __swab32(identify_buffer[4])); > hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD5, > __swab32(identify_buffer[5])); > } > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
