>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@xxxxxxxxxx> writes: Baoyou> We get 4 warnings about global functions without a declaration Baoyou> in the scsi pmcraid driver when building with W=1: Baoyou> drivers/scsi/pmcraid.c:309:6: warning: no previous prototype for Baoyou> 'pmcraid_init_cmdblk' [-Wmissing-prototypes] Baoyou> drivers/scsi/pmcraid.c:404:6: warning: no previous prototype for Baoyou> 'pmcraid_return_cmd' [-Wmissing-prototypes] Baoyou> drivers/scsi/pmcraid.c:1713:6: warning: no previous prototype Baoyou> for 'pmcraid_ioasc_logger' [-Wmissing-prototypes] Baoyou> drivers/scsi/pmcraid.c:3141:1: warning: no previous prototype Baoyou> for 'pmcraid_init_ioadls' [-Wmissing-prototypes] Baoyou> In fact, these functions are only used in the file in which it Baoyou> is declared and don't need a declaration, but can be made Baoyou> static. so this patch marks it 'static'. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html