On Thu, Sep 01, 2016 at 08:25:28PM +0000, Winkler, Tomas wrote: > > On Mon, Jul 18, 2016 at 11:27:50PM +0300, Tomas Winkler wrote: > > > This is a simple platform device used for testing the RPMB subsystem. > > > +static struct platform_device *rpmb_sim_pdev; > > > > A platform device? Ick, no please don't abuse that interface for this type of > > thing. Make it a real device if you have one, and put it in the proper place. If > > it's a "virtual" device, great, use that. But don't make something up like this > > please. > > This is a virtual device (simulation), nothing behind it just a chunk of memory. > Is this there any information missing to make it clearer? Don't make it a platform device, make it a "virtual" device, don't abuse the platform device/driver interface for something that isn't really a platform device. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
