On Wed, Aug 31, 2016 at 02:59:16PM +0200, Tomas Henzl wrote:
> On 26.8.2016 18:44, Don Brace wrote:
> > From: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx>
> >
> > Removed the workaround for the transition to spanning.
> >
> > Reviewed-by: Scott Teel <scott.teel@xxxxxxxxxxxxx>
> > Reviewed-by: Scott Benesh <scott.benesh@xxxxxxxxxxxxx>
> > Signed-off-by: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx>
> > Signed-off-by: Don Brace <don.brace@xxxxxxxxxxxxx>
> > ---
> > drivers/scsi/smartpqi/smartpqi_init.c | 38 +++++++++++++++++----------------
> > 1 file changed, 20 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> > index 6eab38e..9922e31 100644
> > --- a/drivers/scsi/smartpqi/smartpqi_init.c
> > +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> > @@ -3663,6 +3663,18 @@ static int pqi_validate_device_capability(struct pqi_ctrl_info *ctrl_info)
> > return -EINVAL;
> > }
> >
> > + if (!ctrl_info->inbound_spanning_supported) {
> > + dev_err(&ctrl_info->pci_dev->dev,
> > + "the controller does not support inbound spanning\n");
> > + return -EINVAL;
> > + }
> > +
> > + if (ctrl_info->outbound_spanning_supported) {
> > + dev_err(&ctrl_info->pci_dev->dev,
> > + "the controller supports outbound spanning but this driver does not\n");
> > + return -EINVAL;
> > + }
> > +
> > return 0;
> > }
>
> This looks like you are dropping support for a probably older firmware devices,
> is that necessary - can't you continue a keep the support with something similar to that
> 'TEMPHACk' below ?
The question is, if any of these older firmware devices ever left the
Microsemi buildings. If not I _think_ it's save to drop it, as no real
users are harmed.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
