On Mon, Aug 29, 2016 at 09:36:32PM +0000, Don Brace wrote: > > -----Original Message----- [...] > > > > IIRC I asked you to introduce this timeout, as you're calling > > pqi_flush_cache() from the driver's shutdown callback and I still > > doubt users like their shutdown's to hang indefinitely because cache > > flush isn't working. Just my $0.02. > > > > The issue is that we do not know how long to wait. The cache module has gotten > quite large and some flush operations can take longer to complete than others. > That is why we took the timeout value out. OK, thanks for the clarification. I think we can still sort this out when real non-theoretical issues arise. Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
