Hi Andy,
On Tue, Aug 09, 2016 at 08:49:41AM +0530, Andy Grover wrote:
> Hi Varun,
>
> On 04/19/2016 11:30 AM, Varun Prakash wrote:
> > Add void (*iscsit_get_rx_pdu)() to
> > struct iscsit_transport, iscsi-target
> > uses this callback to receive and
> > process Rx iSCSI PDUs.
> >
> > cxgbit.ko needs this callback to
> > reuse iscsi-target Rx thread.
> >
> > Signed-off-by: Varun Prakash <varun@xxxxxxxxxxx>
> > Acked-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> > ---
> > drivers/infiniband/ulp/isert/ib_isert.c | 10 ++++++++++
> > drivers/target/iscsi/iscsi_target.c | 10 ++--------
> > include/target/iscsi/iscsi_transport.h | 1 +
> > 3 files changed, 13 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> > index 411e446..9118d7c 100644
> > --- a/drivers/infiniband/ulp/isert/ib_isert.c
> > +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> > @@ -3273,6 +3273,15 @@ static void isert_free_conn(struct iscsi_conn *conn)
> > isert_put_conn(isert_conn);
> > }
> >
> > +static void isert_get_rx_pdu(struct iscsi_conn *conn)
> > +{
> > + struct completion comp;
> > +
> > + init_completion(&comp);
> > +
> > + wait_for_completion_interruptible(&comp);
> > +}
> > +
>
> Does this mean that the iser rx thread just does nothing and waits to
> receive a signal to exit?
Yes.
>
> If we don't set *iscsit_get_rx_pdu for iser, so the thread exits
> immediately from iscsi_target_rx_thread, would that be an ok change?
I think it may need few more changes to remove Rx thread.
Please see Nicholas's comment on this issue.
https://www.spinics.net/lists/target-devel/msg12269.html
Thanks
Varun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
