Re: [PATCH 01/14] lpfc: Double WQ element count to keep iops up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 11, 2016 at 11:35:48AM -0700, James Smart wrote:
> 
> Double WQ element count to keep iops up
> 
> On embedded io queues, use the default element count, which is twice the
> size of the default large WQE element count.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>
> Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx>
> ---
>  drivers/scsi/lpfc/lpfc_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index adf61b43..64b6313 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -7349,7 +7349,7 @@ lpfc_sli4_queue_create(struct lpfc_hba *phba)
>  		if (phba->fcp_embed_io) {
>  			qdesc = lpfc_sli4_queue_alloc(phba,
>  						      LPFC_WQE128_SIZE,
> -						      LPFC_WQE128_DEF_COUNT);
> +						      phba->sli4_hba.wq_ecount);
>  		} else {
>  			qdesc = lpfc_sli4_queue_alloc(phba,
>  						      phba->sli4_hba.wq_esize,


Hmm what about:

u32 entry_size;

[...]

if (phba->fc_embed_io)
	entry_size = LPFC_WQE128_DEF_SIZE;
else
	entry_size = phba->sli4_hba.wq_esize;

qdesc = lpfc_sli4_queue_alloc(phba,
			      entry_size,
			      phba->sli4_hba.wq_ecount);


Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux