>>>>> "Shaun" == Shaun Tancheff <shaun@xxxxxxxxxxxx> writes: Shaun, Shaun> In sd_setup_discard_cmnd() there are a some discard methods that Shaun> fall back to using WRITE_SAME. It appears that those paths using Shaun> WRITE_SAME should also use the SD_WRITE_SAME_TIMEOUT instead of Shaun> the default SD_TIMEOUT. The expectation is that the UNMAP variants update a translation table of some sort in close to constant time. Potentially with some head and tail zeroing on media. And should therefore easily fall within the 30s limit. But you have a point wrt. SD_LBP_ZERO. It was used for one particular type of array that did zero block detection (and thus didn't actually write anything either). I don't think anybody is using this mode of operation anymore since thin provisioning has been formalized in T10 for quite a while. But I'd be OK with a patch that uses SD_WRITE_SAME_TIMEOUT for that particular code path. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
