On 08/03/2016 07:36 PM, Bart Van Assche wrote:
> On 08/03/2016 06:13 AM, Hannes Reinecke wrote:
>> @@ -2407,15 +2411,21 @@ static void fcoe_ctlr_vn_probe_req(struct
>> fcoe_ctlr *fip,
>> */
>> if (fip->lp->wwpn > rdata->ids.port_name &&
>> !(frport->flags & FIP_FL_REC_OR_P2P)) {
>> + LIBFCOE_FIP_DBG(fip, "vn_probe_req: "
>> + "port_id collision\n");
>> fcoe_ctlr_vn_send(fip, FIP_SC_VN_PROBE_REP,
>> frport->enode_mac, 0);
>
> Some users search through the kernel source tree for error and debug
> messages. For these users it is easier if the entire message occurs on a
> single line. Otherwise this patch looks fine to me.
>
Multiline logging messages; I know.
I have the constant urge to fold everything on 80 chars.
And even checkpatch seems to be unsure whether logging messages
extending beyond 80 chars should be allowed or not.
But okay, one line it is.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
