Re: [PATCH 22/22] fcoe: set default TC priority

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hannes,

[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.7 next-20160803]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hannes-Reinecke/FCoE-VN2VN-fixes/20160803-211619
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All error/warnings (new ones prefixed by >>):

   drivers/scsi/fcoe/fcoe.c: In function 'fcoe_dcb_create':
>> drivers/scsi/fcoe/fcoe.c:2200:3: error: 'ctlr_prio' undeclared (first use in this function)
      ctlr_prio = ffs(fup) ? ffs(fup) - 1 : fcoe_prio;
      ^
   drivers/scsi/fcoe/fcoe.c:2200:3: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/scsi/fcoe/fcoe.c:2201:3: error: 'prio_set' undeclared (first use in this function)
      prio_set = true;
      ^
>> drivers/scsi/fcoe/fcoe.c:2171:6: warning: unused variable 'ctrl_prio' [-Wunused-variable]
     int ctrl_prio = TC_PRIO_BESTEFFORT;
         ^

vim +/ctlr_prio +2200 drivers/scsi/fcoe/fcoe.c

  2165	 * @netdev: The net_device object of the L2 link that should be queried
  2166	 * @port: The fcoe_port to bind FCoE APP priority with
  2167	 * @
  2168	 */
  2169	static void fcoe_dcb_create(struct fcoe_interface *fcoe)
  2170	{
> 2171		int ctrl_prio = TC_PRIO_BESTEFFORT;
  2172		int fcoe_prio = TC_PRIO_INTERACTIVE;
  2173	#ifdef CONFIG_DCB
  2174		int dcbx;
  2175		u8 fup, up;
  2176		struct net_device *netdev = fcoe->realdev;
  2177		struct fcoe_ctlr *ctlr = fcoe_to_ctlr(fcoe);
  2178		struct dcb_app app = {
  2179					.priority = 0,
  2180					.protocol = ETH_P_FCOE
  2181				     };
  2182	
  2183		/* setup DCB priority attributes. */
  2184		if (netdev && netdev->dcbnl_ops && netdev->dcbnl_ops->getdcbx) {
  2185			dcbx = netdev->dcbnl_ops->getdcbx(netdev);
  2186	
  2187			if (dcbx & DCB_CAP_DCBX_VER_IEEE) {
  2188				app.selector = IEEE_8021QAZ_APP_SEL_ETHERTYPE;
  2189				up = dcb_ieee_getapp_mask(netdev, &app);
  2190				app.protocol = ETH_P_FIP;
  2191				fup = dcb_ieee_getapp_mask(netdev, &app);
  2192			} else {
  2193				app.selector = DCB_APP_IDTYPE_ETHTYPE;
  2194				up = dcb_getapp(netdev, &app);
  2195				app.protocol = ETH_P_FIP;
  2196				fup = dcb_getapp(netdev, &app);
  2197			}
  2198	
  2199			fcoe_prio = ffs(up) ? ffs(up) - 1 : 0;
> 2200			ctlr_prio = ffs(fup) ? ffs(fup) - 1 : fcoe_prio;
> 2201			prio_set = true;
  2202		}
  2203	#endif
  2204		fcoe->priority = fcoe_prio;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux