I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>
---
drivers/xen/xen-scsiback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index d6950e0..a9fd45a 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -185,10 +185,10 @@ struct scsiback_tpg {
#define SCSIBACK_INVALID_HANDLE (~0)
static bool log_print_stat;
-module_param(log_print_stat, bool, 0644);
+module_param(log_print_stat, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
static int scsiback_max_buffer_pages = 1024;
-module_param_named(max_buffer_pages, scsiback_max_buffer_pages, int, 0644);
+module_param_named(max_buffer_pages, scsiback_max_buffer_pages, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(max_buffer_pages,
"Maximum number of free pages to keep in backend buffer");
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
