This patch should cause no behavioral change. Even the (removal of) the redundant bit mask should be a nop. So it seems like a bit of an overkill to split them. On 22 July 2016 at 02:45, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Hello. > > On 07/21/2016 09:41 PM, tom.ty89@xxxxxxxxx wrote: > >> From: Tom Yan <tom.ty89@xxxxxxxxx> >> >> 1. Removed a repeated bit masking in ata_mselect_control() >> 2. Moved `wce`/`d_sense` assignment below the page validity checks >> 3. Added/Removed empty lines where appropriate >> >> Signed-off-by: Tom Yan <tom.ty89@xxxxxxxxx> > > > Perhaps Tejun is OK with that, but if you ask me doing 1 task per patch > is a better practice. > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
