On 20 July 2016 at 14:17, Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx> wrote:
> On Wed, 2016-07-20 at 14:16 -0700, Nicholas A. Bellinger wrote:
>> On Fri, 2016-07-08 at 15:43 -0700, Markus Mayer wrote:
>> > After introducing generic strtolower(), iscsi_initiatorname_tolower() is
>> > no longer needed.
>> >
>> > Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
>> > ---
>> > drivers/target/iscsi/iscsi_target_nego.c | 17 +----------------
>> > 1 file changed, 1 insertion(+), 16 deletions(-)
>> >
>> > diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
>> > index 89d34bd..fa20638 100644
>> > --- a/drivers/target/iscsi/iscsi_target_nego.c
>> > +++ b/drivers/target/iscsi/iscsi_target_nego.c
>> > @@ -987,21 +987,6 @@ static int iscsi_target_do_login(struct iscsi_conn *conn, struct iscsi_login *lo
>> > return 0;
>> > }
>> >
>> > -static void iscsi_initiatorname_tolower(
>> > - char *param_buf)
>> > -{
>> > - char *c;
>> > - u32 iqn_size = strlen(param_buf), i;
>> > -
>> > - for (i = 0; i < iqn_size; i++) {
>> > - c = ¶m_buf[i];
>> > - if (!isupper(*c))
>> > - continue;
>> > -
>> > - *c = tolower(*c);
>> > - }
>> > -}
>> > -
>> > /*
>> > * Processes the first Login Request..
>> > */
>> > @@ -1075,7 +1060,7 @@ int iscsi_target_locate_portal(
>> > * RFC-3720 3.2.6.1. section c) that says that iSCSI IQNs
>> > * are NOT case sensitive.
>> > */
>> > - iscsi_initiatorname_tolower(i_buf);
>> > + strtolower(i_buf);
>> >
>> > if (!s_buf) {
>> > if (!login->leading_connection)
>>
>> Applied to target-pending/for-next.
>>
>> Thanks Markus.
>>
>
> Er, my bad. It's not a stand-alone patch..
No, it's not. I was just about to point that out. Patch 1 is taking a
bit of time to get straightened out, so it hasn't been applied yet.
> In that case for the iscsi-target part:
>
> Acked-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Thanks. I'll add the ACK to my tree.
-Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
