On Thu, Jul 07, 2016 at 06:12:12AM +0800, tom.ty89@xxxxxxxxx wrote: > From: Tom Yan <tom.ty89@xxxxxxxxx> > > SAT (as of sat4r05f.pdf) does not require this vendor specific > designator. Besides, we already have the Unit Serial Number VPD. > > Signed-off-by: Tom Yan <tom.ty89@xxxxxxxxx> > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index bfec66f..9f478ad 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -2210,14 +2210,6 @@ static unsigned int ata_scsiop_inq_83(struct ata_scsi_args *args, u8 *rbuf) > rbuf[1] = 0x83; /* this page code */ > num = 4; > > - /* piv=0, assoc=lu, code_set=ACSII, designator=vendor */ > - rbuf[num + 0] = 2; > - rbuf[num + 3] = ATA_ID_SERNO_LEN; > - num += 4; > - ata_id_string(args->id, (unsigned char *) rbuf + num, > - ATA_ID_SERNO, ATA_ID_SERNO_LEN); > - num += ATA_ID_SERNO_LEN; > - If it isn't actually broken, I don't want to change it. It's a userland visible change which is gratuitous. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
