Looks fine, although I wonder if simple calling scsi_device_supports_vpd in scsi_get_vpd_page wouldn't be even better. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html