Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/20/2016 04:48 PM, Arnd Bergmann wrote:
On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote:
On 06/17/2016 05:47 PM, Arnd Bergmann wrote:
-     jiffies_to_timespec(jiffies, &v0);
-     jiffies_to_timespec(lport->boot_time, &v1);
-     fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec);
+     fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ;

Does this patch introduce a 64-bit division? There might still be 32-bit
users of this code.

No, both lport->boot_time and jiffies are 'unsigned long'.

Ah, you're right. Hence:

Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux