On Wed, Jun 15, 2016 at 10:42:17PM +0200, Arnd Bergmann wrote: > When building with -Wextra, we get a lot of warnings for the lpfc driver > concerning expressions that are always true, starting with: > > drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_npiv_init': > drivers/scsi/lpfc/lpfc_attr.c:2786:77: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] > drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_rrq_init': > drivers/scsi/lpfc/lpfc_attr.c:2802:76: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] > drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_suppress_link_up_init': > drivers/scsi/lpfc/lpfc_attr.c:2812:2050: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] > drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_log_verbose_init': > drivers/scsi/lpfc/lpfc_attr.c:3064:1930: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] > > The code works as intented, but it would be nice to shut up the > warning so we don't clutter up build logs with this. Using a > separate inline function for it makes it clear to the compiler > that the comparison is necessary in the caller but still lets > it do the constant-folding. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
