On Wed, 2016-06-08 at 14:14 +0200, Christoph Hellwig wrote: > Hi Nic, > > multiple ports have been on the todo list ever since we put that short > cut in place, but your patches aren't really how this should work. > > The host NQN is not available for the actual drivers - we need to be able > to virtualize it for containers for example, that's why we need to pass > it by pointer depending on the arguments. Also there is no need to > add another sysfs interface - just like for real drivers we can simply > create the ports in configfs and assign an address to it, we just need > to stop ignoring it. > Not sure what you mean, but my patch does not propose 'to add another sysfs interface'. It simply follows what drivers/target/loopback/ already does for scsi, and allocates a controller from nvmet/configfs-ng at subsystem NQN port enable time. I still don't see why a loopback controller on a port of an individual subsystem NQN can't be created + deleted directly from configfs, and operate independently of other loopback controllers on a port of a different subsystem NQNs. > Something like the patch below is the right way, it just needs a bit more > fine tuning and proper test cases: I don't see how adding a internal mutex for loopback ports, and doing internal sequential list lookup holding the global nvmet_config_sem whilst doing nvmet_fabric_ops->add_port() helps to scale at all.. AFAICT for loopback, neither of these is necessary. Why can't a loopback controller on a port for a individual subsystem NQN be created + deleted directly from configfs, independent of other subsystem NQN's loopback controller ports..? Now for rdma, just like with iscsi-target + iser with network portals, we do need to keep an internal list of ports, given that ports can be shared across different target endpoints. That's the part that I'm working on next for nvmet/configfs-ng. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
