On Wed, Jun 08, 2016 at 04:12:27PM +0300, Sagi Grimberg wrote: >> Because it keeps the code simple. If you had actually participated >> on our development list you might have seen that until not too long >> ago we have very fine grainded locks here. In the end Armen convinced >> me that it's easier to maintain if we don't bother with fine grained >> locking outside the fast path, especially as it significantly simplifies >> the discovery implementation. If if it ever turns out to be an >> issue we can change it easily as the implementation is well encapsulated. > > We did change that, and Nic is raising a valid point in terms of having > a global mutex around all the ports. If the requirement of nvme > subsystems and ports configuration is that it should happen fast enough > and scale to the numbers that Nic is referring to, we'll need to change > that back. > > Having said that, I'm not sure this is a real hard requirement for RDMA > and FC in the mid-term, because from what I've seen, the workloads Nic > is referring to are more typical for iscsi/tcp where connections are > cheaper and you need more to saturate a high-speed interconnects, so > we'll probably see this when we have nvme over tcp working. I'm not really worried about connection establishment - that can be changed to RCU locking really easily. I'm a bit more worried about the case where a driver would block long in ->add_port. But let's worry about that if an actual user comes up. The last thing we need in a new driver is lots of complexity for hypothetical use cases, I'm much more interested in having the driver simple, testable and actually tested than optimizing for something. That is to say the priorities here are very different from Nic's goals for the target code. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
