Re: [PATCH 09/14] scsi: Implement scsi_mq_resize_tags()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/02/2016 07:39 AM, Hannes Reinecke wrote:
+int scsi_mq_resize_tags(struct Scsi_Host *shost, int max_tags)
+{
+	return blk_mq_resize_tag_set(&shost->tag_set, max_tags);
+}
+EXPORT_SYMBOL_GPL(scsi_mq_resize_tags);

What is the meaning of the max_tags argument? Does it include the reserved tag count or not? If not, shouldn't the number of reserved tags be added before calling blk_mq_resize_tag_set()? Please document the meaning of the max_tags argument.

Please also consider choosing a name for this function that is more consistent with the function names used in the block layer e.g. scsi_mq_update_tag_depth().

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux