On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote: > From: bryantly <bryantly@xxxxxxxxxxxxxxxxxx> Please use your whole name here and for your sign-off like: From: Bryant G. Ly <bryantly@xxxxxxxxxxxxxxxxxx> Signed-off-by: Bryant G. Ly <bryantly@xxxxxxxxxxxxxxxxxx> > This patch removes forward declarations and re-organizes the > functions within the driver. This patch also fixes MAINTAINERS > for ibmvscsis. trivial note: > diff --git a/drivers/scsi/ibmvscsi/ibmvscsis.c b/drivers/scsi/ibmvscsi/ibmvscsis.c [] > static inline long h_copy_rdma(s64 length, u64 sliobn, u64 slioba, > u64 dliobn, u64 dlioba) > { > Functions like this would be less indented and less line wrapped for 80 columns if they were written: if (!se_cmd->residual_count) return; [unindented one level...] etc... -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html