Re: [PATCH] scsi_lib: correctly retry failed zero length REQ_TYPE_FS commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "James" == James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> writes:

James> When SCSI was written, all commands coming from the filesystem
James> (REQ_TYPE_FS commands) had data.  This meant that our signal for
James> needing to complete the command was the number of bytes completed
James> being equal to the number of bytes in the request.
James> Unfortunately, with the advent of flush barriers, we can now get
James> zero length REQ_TYPE_FS commands, which confuse this logic
James> because they satisfy the condition every time.  This means they
James> never get retried even for retryable conditions, like UNIT
James> ATTENTION because we complete them early assuming they're done.
James> Fix this by special casing the early completion condition to
James> recognise zero length commands with errors and let them drop
James> through to the retry code.

Applied to 4.7/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux