Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 19, 2016 at 9:30 PM, Varun Prakash <varun@xxxxxxxxxxx> wrote:
> cxgbit.h - This file contains data structure
> definitions for cxgbit.ko.
>
> cxgbit_lro.h - This file contains data structure
> definitions for LRO support.
>
> cxgbit_main.c - This file contains code for
> registering with iscsi target transport and
> cxgb4 driver.
>
> cxgbit_cm.c - This file contains code for
> connection management.
>
> cxgbit_target.c - This file contains code
> for processing iSCSI PDU.
>
> cxgbit_ddp.c - This file contains code for
> Direct Data Placement.

Wait,

You are adding many K's LOCs to handle things like CM (connection
management), DDP and LRO. But your upstream solution must be using CM
and DDP (and LRO as well) for the HW offloaded initiator side as well,
not to mention the iWARP side of things.

There must be some way to refactor things instead of repeating the
same bits over and over, thoughts?

Or.

>  drivers/target/iscsi/Kconfig                |    2 +
>  drivers/target/iscsi/Makefile               |    1 +
>  drivers/target/iscsi/cxgbit/Kconfig         |    7 +
>  drivers/target/iscsi/cxgbit/Makefile        |    6 +
>  drivers/target/iscsi/cxgbit/cxgbit.h        |  353 +++++
>  drivers/target/iscsi/cxgbit/cxgbit_cm.c     | 2086 +++++++++++++++++++++++++++
> drivers/target/iscsi/cxgbit/cxgbit_ddp.c    |  325 +++++
> drivers/target/iscsi/cxgbit/cxgbit_lro.h    |   72 +
> drivers/target/iscsi/cxgbit/cxgbit_main.c   |  701 +++++++++
>  drivers/target/iscsi/cxgbit/cxgbit_target.c | 1561 ++++++++++++++++++++
> 10 files changed, 5114 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux