Re: [PATCH 08/10] aacraid: Remove code to needlessly complete fib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 27, 2016 at 04:34:35PM +0000, Raghava Aditya Renukunta wrote:
> 
> Hello Johannes,
> 
> > > +                             dev_info(&dev->pdev->dev,
> > > +                             "Invalid callback_fib[%d] (*%p)(%p)\n",
> > > +                             index, fib->callback, fib->callback_data);
> > 
> > I'm not sure INFO is the right logging level for this. WARN or ERROR might be
> > more suited.
> 
> I intended it be an acknowledgement that we ran into this issue. That was why I used info,
> It should not impact the flow of the driver.

OK, I'm fine with the explanation

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux