On 04/25/2016 09:16 AM, Douglas Gilbert wrote:
+static unsigned int scsi_debug_lbp(void)
+{
+ return ((0 == sdebug_fake_rw) &&
+ (sdebug_lbpu | sdebug_lbpws | sdebug_lbpws10));
+}
Same comment here as for a previous patch: please do not introduce
superfluous parentheses and please use logical or instead of binary or
for combining boolean variables.
@@ -1970,7 +1965,7 @@ resp_mode_sense(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
(devip->target * 1000) - 3;
/* set DPOFUA bit for disks */
if (0 == sdebug_ptype)
- dev_spec = (DEV_READONLY(target) ? 0x80 : 0x0) | 0x10;
+ dev_spec = 0x10; /* would be 0x81 if read-only */
else
dev_spec = 0x0;
if (msense_6) {
This change has not been explained in the patch description. Should it
perhaps be merged into another patch of this series?
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
