I have fcoe for testing. I will pull this in next week and test it. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services ----- Original Message ----- From: "James Bottomley" <jejb@xxxxxxxxxxxxxxxxxx> To: "Sebastian Andrzej Siewior" <bigeasy@xxxxxxxxxxxxx>, "Christoph Hellwig" <hch@xxxxxxxxxxxxx> Cc: linux-scsi@xxxxxxxxxxxxxxx, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, "Vasu Dev" <vasu.dev@xxxxxxxxx>, rt@xxxxxxxxxxxxx, fcoe-devel@xxxxxxxxxxxxx, "Chad Dupuis" <chad.dupuis@xxxxxxxxxx> Sent: Friday, April 22, 2016 11:49:45 AM Subject: Re: [PREEMPT-RT] [PATCH v2] scsi/fcoe: convert to kworker On Fri, 2016-04-22 at 17:27 +0200, Sebastian Andrzej Siewior wrote: > On 04/12/2016 05:16 PM, Sebastian Andrzej Siewior wrote: > > The driver creates its own per-CPU threads which are updated based > > on > > CPU hotplug events. It is also possible to use kworkers and remove > > some > > of the kthread infrastrucure. > > > > The code checked ->thread to decide if there is an active per-CPU > > thread. By using the kworker infrastructure this is no longer > > possible (or > > required). The thread pointer is saved in `kthread' instead of > > `thread' so > > anything trying to use thread is caught by the compiler. Currently > > only the > > bnx2fc driver is using struct fcoe_percpu_s and the kthread member. > > > > After a CPU went offline, we may still enqueue items on the > > "offline" > > CPU. This isn't much of a problem. The work will be done on a > > random > > CPU. The allocated crc_eof_page page won't be cleaned up. It is > > probably > > expected that the CPU comes up at some point so it should not be a > > problem. The crc_eof_page memory is released of course once the > > module is > > removed. > > > > This patch was only compile-tested due to -ENODEV. > > > > Cc: Vasu Dev <vasu.dev@xxxxxxxxx> > > Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx> > > Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> > > Cc: Christoph Hellwig <hch@xxxxxx> > > Cc: fcoe-devel@xxxxxxxxxxxxx > > Cc: linux-scsi@xxxxxxxxxxxxxxx > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > > --- > > v1…v2: use kworker instead of smbthread as per hch > > > > If you want this I would the same for the two bnx drivers. > > *ping* Ping what? You've sent in an untested patch that looks to be a big change. It's definitely not going in until it's tested. Why don't you see if you can recruit an FCoE person to your cause and get them to test it. It looks like you're looking for testing on bnx2fc, correct? In which case cc'ing a bnx2fc person might have been helpful (cc added). James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
