On 04/14/2016 06:07 PM, Tejun Heo wrote: > On Thu, Apr 14, 2016 at 05:59:48PM +0200, Hannes Reinecke wrote: >> For this patch, yes, you are right. >> However, the ZAC enablement patches later on submit READ LOG EXT commands >> (for REPORT ZONES), and _they_ benefit from NCQ encapsulation. > > Umm... so, you can't use ata_exec_internal() outside of EH context. > Right, I've checked the overall situation. Yes, there is an NCQ encapsulation for READ LOG EXT, but indeed we cannot sensibly use it from an EH context. And the only other position where we would need it is during device initialisation, which is hardly performance critical. So I'll be dropping this patch from the next round of submissions and will just keep the command definitions. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
