Re: [PATCH] scsi_dh_alua: Declare local functions static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/14/2016 07:27 PM, Bart Van Assche wrote:
> This patch avoids that building with W=1 causes gcc to report the
> following type of warning:
> 
>     no previous prototype for ... [-Wmissing-prototypes]
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Ewan Milne <emilne@xxxxxxxxxx>
> ---
>  drivers/scsi/device_handler/scsi_dh_alua.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 8eaed05..e034f12 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -190,8 +190,8 @@ static int submit_stpg(struct scsi_device *sdev, int group_id,
>  				      ALUA_FAILOVER_RETRIES, NULL, req_flags);
>  }
>  
> -struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size,
> -					 int group_id)
> +static struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size,
> +						int group_id)
>  {
>  	struct alua_port_group *pg;
>  
> @@ -219,8 +219,8 @@ struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size,
>   * Allocate a new port_group structure for a given
>   * device.
>   */
> -struct alua_port_group *alua_alloc_pg(struct scsi_device *sdev,
> -				      int group_id, int tpgs)
> +static struct alua_port_group *alua_alloc_pg(struct scsi_device *sdev,
> +					     int group_id, int tpgs)
>  {
>  	struct alua_port_group *pg, *tmp_pg;
>  
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux