Re: [PATCHv2 03/14] libsas: Define ATA_CMD_NCQ_NON_DATA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/04/2016 11:25, Hannes Reinecke wrote:
On 04/12/2016 12:03 PM, John Garry wrote:
On 12/04/2016 07:47, Hannes Reinecke wrote:
Define the NCQ NON DATA command and update libsas to handle it
correctly.

Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
---
   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 +
   drivers/scsi/isci/request.c            | 3 ++-
   drivers/scsi/libsas/sas_ata.c          | 3 ++-
   drivers/scsi/mvsas/mv_sas.c            | 3 ++-
   drivers/scsi/pm8001/pm8001_sas.c       | 3 ++-
   include/linux/ata.h                    | 1 +
   include/trace/events/libata.h          | 1 +
   7 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index fc2e767..ebaf5ab 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
@@ -1575,6 +1575,7 @@ static u8 get_ata_protocol(u8 cmd, int
direction)
       case ATA_CMD_FPDMA_READ:
       case ATA_CMD_FPMDA_RECV:
       case ATA_CMD_FPDMA_SEND:
+    case ATA_CMD_NCQ_NON_DATA:
       return SATA_PROTOCOL_FPDMA;


I'm going to double-check this. It may correspond to
SATA_PROTOCOL_NONDATA, and not SATA_PROTOCOL_FPDMA.


So I got confirmation that SATA_PROTOCOL_FPDMA is correct for this type of command and we do support it.

If we want to test is it ok just to take this patchset and the other advised prerequisite patchsets?

Thanks. The spec is not exactly clear in that regard...

Cheers,

Hannes



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux