Re: [PATCH 2/3] qla2xxx: Remove set-but-not-used variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/31/16 08:24, Quinn Tran wrote:
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index c1461d2..97fcbf2 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -311,13 +311,6 @@ static void tcm_qla2xxx_free_cmd(struct
qla_tgt_cmd *cmd)
   */
  static int tcm_qla2xxx_check_stop_free(struct se_cmd *se_cmd)
  {
-	struct qla_tgt_cmd *cmd;
-
-	if ((se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB) == 0) {
-		cmd = container_of(se_cmd, struct qla_tgt_cmd, se_cmd);
-		cmd->cmd_flags |= BIT_14;
-	}
-
  	return target_put_sess_cmd(se_cmd);
  }

Apart from the qla24xx_els_dcmd_iocb() thingy (which has nothing to do
with your patch)
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

QT: We use the cmd_flags portion for debugging crashes.  It’s our form of tracing. Please do not delete. Thanks.

Hello Quinn,

OK, I will restore that code.

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux