Agreed. It’s one of our pending action items for cleanup.
Regards,
Quinn Tran
-----Original Message-----
From: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
Date: Thursday, March 31, 2016 at 8:22 AM
To: Quinn Tran <quinn.tran@xxxxxxxxxx>, James Bottomley <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags
>On 03/31/16 08:16, Quinn Tran wrote:
>> We use these flags for debugging purpose in crash cases.
>
>Hello Quinn,
>
>It must be inconvenient to have to look up the meaning of the individual
>bits of the cmd_flags variable when analyzing a kernel crash. How about
>preserving all these flags and to assign a meaningful name to each flag
>instead of using bit numbers?
>
>Thanks,
>
>Bart.
>
��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
