Re: [PATCH] scsi_common: do not clobber fixed sense information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/18/2016 01:01 AM, Hannes Reinecke wrote:
For fixed sense the information field is 32 bits, to we need
to truncate the information field to avoid clobbering the
sense code.

Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
---
  drivers/scsi/scsi_common.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c
index c126966..3459009 100644
--- a/drivers/scsi/scsi_common.c
+++ b/drivers/scsi/scsi_common.c
@@ -279,7 +279,7 @@ int scsi_set_sense_information(u8 *buf, int buf_len, u64 info)
  		put_unaligned_be64(info, &ucp[4]);
  	} else if ((buf[0] & 0x7f) == 0x70) {
  		buf[0] |= 0x80;
-		put_unaligned_be64(info, &buf[3]);
+		put_unaligned_be32((u32)info, &buf[3]);
  	}

  	return 0;

Hello Hannes,

Please Cc stable for this patch.

Are you aware that the explicit cast to u32 can be left out? Without that cast the compiler implicitly performs casting from u64 to u32.

Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux