On 03/15/2016 12:57 AM, Martin K. Petersen wrote: >>>>>> "Hannes" == Hannes Reinecke <hare@xxxxxxx> writes: > >> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c >> index 97074c9..929204b 100644 >> --- a/drivers/scsi/scsi_scan.c >> +++ b/drivers/scsi/scsi_scan.c >> @@ -96,10 +96,11 @@ MODULE_PARM_DESC(max_luns, >> #define SCSI_SCAN_TYPE_DEFAULT "sync" >> #endif >> >> -char scsi_scan_type[6] = SCSI_SCAN_TYPE_DEFAULT; >> +char scsi_scan_type[9] = SCSI_SCAN_TYPE_DEFAULT; >> >> -module_param_string(scan, scsi_scan_type, sizeof(scsi_scan_type), S_IRUGO); >> -MODULE_PARM_DESC(scan, "sync, async or none"); >> +module_param_string(scan, scsi_scan_type, sizeof(scsi_scan_type), >> + S_IRUGO|S_IWUSR); >> +MODULE_PARM_DESC(scan, "sync, async, disabled, or none"); > > So "disabled" is "sometimes enabled" and "none" is "really disabled"? > 'disabled' means: disable automatic scanning, but allow manual scanning via the 'scan' attribute. >> static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ + 18; >> >> @@ -1604,7 +1605,9 @@ static void __scsi_scan_target(struct device *parent, unsigned int channel, >> * @channel: channel to scan >> * @id: target id to scan >> * @lun: Specific LUN to scan or SCAN_WILD_CARD >> - * @rescan: passed to LUN scanning routines >> + * @rescan: passed to LUN scanning routines; 0 for no rescan, 1 to rescan >> + * existing LUNs, and 2 to override any 'scan_disabled' setting >> + * from the host. > > enum SCSI_SCAN_FOO_BAR instead of magic values, please. > Okay. > What's this "scan_disabled" setting from the host? > It's called a 'typo' and found quite frequently in the wilds :-) I'll be sending a respin. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
