Martin, the only way i can avoid the circular dependency is to move the routines from ufs_quirks.c into ufshcd.c. i will upload V8 soon thanks, Yaniv >>>>>> "Yaniv" == Yaniv Gardi <ygardi@xxxxxxxxxxxxxx> writes: > > Yaniv> Currently we use the host quirks mechanism in order to handle > Yaniv> both device and host controller quirks. In order to support > Yaniv> various of UFS devices we should separate handling the device > Yaniv> quirks from the host controller's. > > This patch causes a circular dependency: > > depmod: ERROR: Cycle detected: ufshcd -> ufs_quirks -> ufshcd > > Please fix! > > -- > Martin K. Petersen Oracle Linux Engineering > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html