On 03/10/2016 11:14 AM, Sumit Saxena wrote: > There are few MFI adapters which do not support MR_DCMD_PD_LIST_QUERY so > if MFI adapters fail this DCMD, it should not be considered as FATAL and > driver should not issue kill adapter and set per controller's instance > variable- pd_list_not_supported so that same variable can be used inside > functions- slave_alloc and slave_configure to allow firmware scan. > > Killing adapter because of DCMD failure when this DCMD is not supported > causes driver's probe getting failed. This issue got introduced because > of below commit when MFI IO timeout handling was introduced- > > 6d40afb megaraid_sas: MFI IO timeout handling > > Killing adapter in case of this DCMD failure should be limited to Fusion > adapters only. Per controller's instance variable allow_fw_scan is removed > as pd_list_not_supported better reflect the purpose. > > Signed-off-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx> > --- > drivers/scsi/megaraid/megaraid_sas.h | 2 +- > drivers/scsi/megaraid/megaraid_sas_base.c | 14 ++++++++++---- > 2 files changed, 11 insertions(+), 5 deletions(-) > Took you a while to figure that one out :-) This was actually the main issue why I started with the DCMD timeout stuff. Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
