On Mon, Feb 15, 2016 at 07:07:19PM +0200, Sagi Grimberg wrote: > >+ if ((conn->conn_transport->transport_type == ISCSI_TCP) || > >+ (conn->conn_transport->transport_type == ISCSI_TCP_CXGB4)) > > complete(&conn->conn_logout_comp); > > IMO, this is an indication that this condition is a bandage in the first > place... Agreed. Nevermind the fact that a spurious complete() is perfectly harmless.. > While this is unrelated to the patch set, we should look into the iscsi > termination sequences more closely and look if we can dispatch some > logic to the drivers in places they defer. It will make the code much > less complicated. Yes, all I've seen in this series so far suggest that the integration is a complete mess. I think this really needs to go back to the drawing board. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
