No I mean I no longer thinks that this condition needs to be inverted. I just THOUGHT that !scsi_get_vpd_page is true if it DIDN'T get the page. On 27 February 2016 at 04:57, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, 2016-02-27 at 04:32 +0800, Tom Yan wrote: >> Oh I made a mistake on this one then. >> >> Since I send it with another patch, should I resend that alone? > > Yes, that's fine. but you need to explain as part of the changelog why > this condition needs inverting because your Subject just says "as per > the comment" which makes no sense if you're changing the comment. > > James > > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
