Hi Varun & Co, Apologies for the delayed follow up here. On Sun, 2016-02-14 at 23:00 +0530, Varun Prakash wrote: > This RFC series is for Chelsio iSCSI target offload > driver(cxgbit.ko). > > cxgbit.ko registers with iSCSI target transport > and offloads multiple CPU intensive tasks to > Chelsio T5 adapters. > > Chelsio T5 adapter series has following offload > features for iSCSI - > -TCP/IP offload. > -iSCSI PDU recovery by reassembling TCP segments. > -Header and Data Digest offload. > -iSCSI segmentation offload(ISO). > -Direct Data Placement(DDP). > > Please review this series. > After spending time over the last weeks to understand how cxgbit.ko offloads work in patches #27-34, I think overall the new driver is in very good shape. Wrt to the patches to existing iscsi-target code in patches #13-26, I need more time over the next days to consider the changes and/or better alternatives, along with Sagi's earlier comments. AFAICT it's mostly smaller items, but it would be worth the discussion to see if/where some larger improvements to existing iscsi-target code can be made beyond the initial merge. That said, this series has been added as-is to target-pending/for-next-merge, to be picked up for the first round of linux-next integration for drivers/net/ethernet/chelsio/ vs. DaveM's net tree, and 0-day build testing. Let's plan a RFC-v2 follow up sometime next week to address individual comments, and to git squash patches #27-34 into a single merge-able commit. Thank you, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html