On 02/18/2016 10:55 PM, Bart Van Assche wrote: > On 02/15/2016 12:24 AM, Hannes Reinecke wrote: >> Add an 'access_state' attribute to struct scsi_device to >> display the asymmetric LUN access state. > > Do we really need to add this attribute to SCSI devices that do not > support ALUA, e.g. ATA devices ? From a system on which this patch > series has been installed: > > [root ~]# lsscsi | grep 0:0:0:0 > [0:0:0:0] disk ATA ST1000NM0033-9ZM GA67 /dev/sda > [root ~]# cat /sys/class/scsi_device/0:0:0:0/device/access_state > active/optimized > Well. I've hit the same issue with my patches exposing vpd pages to sysfs. Thing is, the sysfs entries are created during scsi_alloc_sdev(). But we only know if the have these entries during scsi_add_lun(), ie way beyond that point. So ATM we don't have a chance of selectively enabling them. Any change here would require a modification to the core sysfs behaviour, which might not that easy. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
