Re: [PATCHv7 21/23] scsi_dh_alua: use common definitions for ALUA state

[Bart Van Assche <bart.vanassche@xxxxxxxxxxx>]

On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
> @@ -180,7 +172,7 @@ static int submit_stpg(struct scsi_device *sdev, int group_id,
>
>   	/* Prepare the data buffer */
>   	memset(stpg_data, 0, stpg_len);
> -	stpg_data[4] = TPGS_STATE_OPTIMIZED & 0x0f;
> +	stpg_data[4] = SCSI_ACCESS_STATE_OPTIMAL & 0x0f;
>   	put_unaligned_be16(group_id, &stpg_data[6]);

In the previous patch a symbolic name for the ALUA state mask has been 
introduced (SCSI_ACCESS_STATE_MASK). Hence please either leave out "& 
0x0f" from the above code or use that constant.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html