On Fri, Feb 12, 2016 at 11:52 AM, Joao Pinto <Joao.Pinto@xxxxxxxxxxxx> wrote: > Hi Rob, > > On 2/12/2016 4:36 PM, Rob Herring wrote: >> On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote: >>> +Required properties: >>> +- compatible : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1" >>> + or "snps,ufshcd-2.0") >> >> History has taught us this needs to have a vendor specific compatible >> string as well. Don't necessarily have to define it now, but just state >> a vendor string is needed too. > > The compatibility string already as the "snps" which is the acronym for Synopsys > which is the HW Controller vendor. Isn't this enough? Go look drivers for any licensed IP: DW PCIe, DW GMAC, USB EHCI controllers (pretty much all licensed IP), etc. They all have variations either from versions of the IP, configuration of the IP, "enhancements" by the licensee, integration quirks, or all of the above. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html