On 01/29/2016 11:05 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Cc: Vu Pham <vu@xxxxxxxxxxxx>
Cc: Sagi Grimberg <sagig@xxxxxxxxxxxx>
Cc: Bart Van Assche <bvanassche@xxxxxxx>
Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Hello Nic,
A patch description should not only explain what has been changed but
also why that change is considered useful. That last part is missing
from the description of this patch. Is the purpose of this patch perhaps
to improve performance ? If so then you should provide measurement data
that shows that this patch really improves performance. Personally I
doubt this patch improves performance because in the ib_srpt driver all
ioctx allocations happen on the same CPU core, namely the CPU core the
completion interrupt has been assigned to.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
