Re: [PATCH 01/12] be2iscsi: Remove unused mcc_cq_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "James" == James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> writes:

James> On Mon, 2016-02-01 at 15:42 +0530, Jitendra Bhivare wrote:
>> mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is
>> called only when all interrupts are disabled from mgmt_epfw_cleanup
>> during unloading of driver. There is no other context where there can
>> be contention for the processing of CQ.

James> Removing a lock is not a bug fix unless it's causing a user
James> visible problem, so this patch (and quite a lot of others in this
James> series) should go through the merge window process.

James> For things that cause user visible problems, we need a
James> description of the problem in the changelog and a cc to stable
James> unless it was a regression in the 4.4+ merge window.

I applied be2iscsi 11.0.0.0 to 4.6/scsi-queue about a week ago so this
is inevitably merge window material.

Jitendra, it's a good idea to spell out the intended target release or
repository when you post patches. Makes it easier for everyone.

Instead of "[PATCH 00/12] be2iscsi: critical fixes for 11.0.0.0" I would
suggest something like "[PATCH 00/12] be2iscsi: important fixes for
11.0.0.0 driver in 4.6/scsi-queue".

That way we know which tree to apply the patches to and it's clear that
it's an incremental update to a previously queued series.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux